Add MANUAL_OPERATION_NONE to ManualOperation enum#5564
Merged
Conversation
Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
Warashi
requested review from
ffjlabo,
khanhtc1202 and
t-kikuc
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5564 +/- ##
==========================================
+ Coverage 26.31% 26.32% +0.01%
==========================================
Files 467 467
Lines 50099 50099
==========================================
+ Hits 13183 13189 +6
+ Misses 35861 35855 -6
Partials 1055 1055 ☔ View full report in Codecov by Sentry. |
t-kikuc
approved these changes
Feb 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
as title
Why we need it:
We need a way to represent that no manual operation is available on the Web UI.
It's not unknown, so it's not a good way to use UNKNOWN to represent it.
Which issue(s) this PR fixes:
Part of #5367
Does this PR introduce a user-facing change?: No