Skip to content

Add Config field to PipedPlugin#5576

Merged
Warashi merged 2 commits intomasterfrom
add-config-field-to-piped-plugin
Feb 18, 2025
Merged

Add Config field to PipedPlugin#5576
Warashi merged 2 commits intomasterfrom
add-config-field-to-piped-plugin

Conversation

@Warashi
Copy link
Member

@Warashi Warashi commented Feb 17, 2025

What this PR does:

  • Add Config field to PipedPlugin for plugin configuration.
  • Update comment for DeployTargets in PipedPlugin

Why we need it:

We want to add a plugin configuration that does not depend on deploy targets.

Which issue(s) this PR fixes:

Part of #4980

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
@codecov
Copy link

codecov bot commented Feb 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 26.34%. Comparing base (14f3d0b) to head (4f2ec47).
Report is 7 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5576   +/-   ##
=======================================
  Coverage   26.33%   26.34%           
=======================================
  Files         467      467           
  Lines       50114    50114           
=======================================
+ Hits        13198    13202    +4     
+ Misses      35860    35857    -3     
+ Partials     1056     1055    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Warashi Warashi marked this pull request as ready for review February 17, 2025 05:00
Copy link
Member

@khanhtc1202 khanhtc1202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@Warashi Warashi enabled auto-merge (squash) February 18, 2025 07:06
@Warashi Warashi merged commit 31e121c into master Feb 18, 2025
18 checks passed
@Warashi Warashi deleted the add-config-field-to-piped-plugin branch February 18, 2025 15:11
@github-actions github-actions bot mentioned this pull request Mar 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants