Skip to content

Add base plugin code for k8s multicluster plugin#5592

Merged
t-kikuc merged 1 commit intomasterfrom
add-base-code-for-k8s-multi-cluster-plugin
Feb 20, 2025
Merged

Add base plugin code for k8s multicluster plugin#5592
t-kikuc merged 1 commit intomasterfrom
add-base-code-for-k8s-multi-cluster-plugin

Conversation

@ffjlabo
Copy link
Member

@ffjlabo ffjlabo commented Feb 20, 2025

What this PR does:

as title.
I copied almost all from the example plugin.

Why we need it:

We decided to implement multi-cluster features as another plugin.

Which issue(s) this PR fixes:

Part of #5006

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com>
@codecov
Copy link

codecov bot commented Feb 20, 2025

Codecov Report

Attention: Patch coverage is 0% with 16 lines in your changes missing coverage. Please review.

Project coverage is 26.26%. Comparing base (7d9c00c) to head (8b1e3af).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...p/pipedv1/plugin/kubernetes_multicluster/plugin.go 0.00% 10 Missing ⚠️
...app/pipedv1/plugin/kubernetes_multicluster/main.go 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5592      +/-   ##
==========================================
- Coverage   26.27%   26.26%   -0.01%     
==========================================
  Files         470      472       +2     
  Lines       50372    50388      +16     
==========================================
  Hits        13234    13234              
- Misses      36078    36094      +16     
  Partials     1060     1060              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@khanhtc1202 khanhtc1202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Member

@t-kikuc t-kikuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

)

func main() {
sdk.RegisterPipelineSyncPlugin(&plugin{})
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we will use RegisterDeploymentPlugin(...) after starting implementing the DeploymentPlugin

@t-kikuc t-kikuc merged commit 7b78a17 into master Feb 20, 2025
16 of 18 checks passed
@t-kikuc t-kikuc deleted the add-base-code-for-k8s-multi-cluster-plugin branch February 20, 2025 07:30
@github-actions github-actions bot mentioned this pull request Mar 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants