Skip to content

Add empty methods which need for implementing the k8s plugin with the SDK#5602

Merged
ffjlabo merged 2 commits intomasterfrom
prepare-for-rewriting-k8s-quicksync-with-sdk
Feb 26, 2025
Merged

Add empty methods which need for implementing the k8s plugin with the SDK#5602
ffjlabo merged 2 commits intomasterfrom
prepare-for-rewriting-k8s-quicksync-with-sdk

Conversation

@ffjlabo
Copy link
Member

@ffjlabo ffjlabo commented Feb 26, 2025

What this PR does:

as title.
I plan to rewrite it with SDK as follow.

  • implement the current logic with SDK into struct sdkPlugin.
  • Replace current struct plugin after implementing all methods which need for the interface DeploymentPlugin.

Why we need it:

We want to rewrite plugin by using SDK while keeping the current k8s plugin work.
Also, I want to rewrite it before implementing multi cluster plugin.

Which issue(s) this PR fixes:

Part of #4980 #5006

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

@codecov
Copy link

codecov bot commented Feb 26, 2025

Codecov Report

Attention: Patch coverage is 0% with 21 lines in your changes missing coverage. Please review.

Project coverage is 26.25%. Comparing base (c1a62c5) to head (914cf2c).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
pkg/app/pipedv1/plugin/kubernetes/plugin.go 0.00% 16 Missing ⚠️
pkg/app/pipedv1/plugin/kubernetes/main.go 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5602      +/-   ##
==========================================
- Coverage   26.27%   26.25%   -0.02%     
==========================================
  Files         474      474              
  Lines       50475    50496      +21     
==========================================
- Hits        13263    13259       -4     
- Misses      36150    36174      +24     
- Partials     1062     1063       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com>
Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com>
@ffjlabo ffjlabo force-pushed the prepare-for-rewriting-k8s-quicksync-with-sdk branch from 5506067 to 914cf2c Compare February 26, 2025 01:53
@ffjlabo ffjlabo changed the title Add empty methods which need for implementing the plugin with the SDK Add empty methods which need for implementing the k8s plugin with the SDK Feb 26, 2025
@ffjlabo ffjlabo marked this pull request as ready for review February 26, 2025 01:59
@ffjlabo ffjlabo enabled auto-merge (squash) February 26, 2025 02:08
var _ sdk.DeploymentPlugin[sdk.ConfigNone, kubeconfig.KubernetesDeployTargetConfig] = (*sdkPlugin)(nil)

func (p *sdkPlugin) Name() string {
return "kubernetes"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's update it to like 'kubernetes-multicluster' later

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is for rewriting kubernetes plugin. So I think the plugin name is correct.

@ffjlabo ffjlabo merged commit 330c622 into master Feb 26, 2025
16 of 18 checks passed
@ffjlabo ffjlabo deleted the prepare-for-rewriting-k8s-quicksync-with-sdk branch February 26, 2025 02:15
@github-actions github-actions bot mentioned this pull request Mar 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants