Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5602 +/- ##
==========================================
- Coverage 26.27% 26.25% -0.02%
==========================================
Files 474 474
Lines 50475 50496 +21
==========================================
- Hits 13263 13259 -4
- Misses 36150 36174 +24
- Partials 1062 1063 +1 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com>
Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com>
5506067 to
914cf2c
Compare
Warashi
approved these changes
Feb 26, 2025
t-kikuc
approved these changes
Feb 26, 2025
| var _ sdk.DeploymentPlugin[sdk.ConfigNone, kubeconfig.KubernetesDeployTargetConfig] = (*sdkPlugin)(nil) | ||
|
|
||
| func (p *sdkPlugin) Name() string { | ||
| return "kubernetes" |
Member
There was a problem hiding this comment.
let's update it to like 'kubernetes-multicluster' later
Member
Author
There was a problem hiding this comment.
This is for rewriting kubernetes plugin. So I think the plugin name is correct.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
as title.
I plan to rewrite it with SDK as follow.
sdkPlugin.pluginafter implementing all methods which need for the interfaceDeploymentPlugin.Why we need it:
We want to rewrite plugin by using SDK while keeping the current k8s plugin work.
Also, I want to rewrite it before implementing multi cluster plugin.
Which issue(s) this PR fixes:
Part of #4980 #5006
Does this PR introduce a user-facing change?: