Skip to content

Add LivestatePlugin to implement Livestate/DriftDetection with SDK#5603

Merged
Warashi merged 3 commits intomasterfrom
livestate-plugin-sdk
Mar 4, 2025
Merged

Add LivestatePlugin to implement Livestate/DriftDetection with SDK#5603
Warashi merged 3 commits intomasterfrom
livestate-plugin-sdk

Conversation

@Warashi
Copy link
Member

@Warashi Warashi commented Feb 26, 2025

What this PR does:

This PR adds the interface definition of LivestatePlugin and the codes to run it.

Why we need it:

To implement livestate feature with SDK

Which issue(s) this PR fixes:

Part of #5530

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

…live state retrieval

Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
@codecov
Copy link

codecov bot commented Feb 26, 2025

Codecov Report

Attention: Patch coverage is 0% with 32 lines in your changes missing coverage. Please review.

Project coverage is 26.22%. Comparing base (c1a62c5) to head (171de2e).
Report is 15 commits behind head on master.

Files with missing lines Patch % Lines
pkg/plugin/sdk/livestate.go 0.00% 20 Missing ⚠️
pkg/plugin/sdk/sdk.go 0.00% 12 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5603      +/-   ##
==========================================
- Coverage   26.27%   26.22%   -0.05%     
==========================================
  Files         474      475       +1     
  Lines       50475    50528      +53     
==========================================
- Hits        13263    13253      -10     
- Misses      36150    36212      +62     
- Partials     1062     1063       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Warashi Warashi marked this pull request as ready for review February 26, 2025 04:16
Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
Copy link
Member

@t-kikuc t-kikuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Let's try

@Warashi Warashi enabled auto-merge (squash) February 26, 2025 06:20
Copy link
Member

@ffjlabo ffjlabo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lt's try

@Warashi Warashi merged commit 04394f5 into master Mar 4, 2025
16 of 18 checks passed
@Warashi Warashi deleted the livestate-plugin-sdk branch March 4, 2025 00:59
@github-actions github-actions bot mentioned this pull request Mar 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants