Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5605 +/- ##
==========================================
+ Coverage 26.53% 26.56% +0.03%
==========================================
Files 474 474
Lines 50505 50535 +30
==========================================
+ Hits 13399 13427 +28
- Misses 36042 36045 +3
+ Partials 1064 1063 -1 ☔ View full report in Codecov by Sentry. |
Warashi
reviewed
Feb 26, 2025
Member
Warashi
left a comment
There was a problem hiding this comment.
Almost LGTM. I commented on nitpicks.
| return out | ||
| } | ||
|
|
||
| func BuildQuickSyncPipeline(autoRollback bool, now time.Time) []sdk.QuickSyncStage { |
Member
There was a problem hiding this comment.
👀 The parameter now seems to be not used.
e96d964 to
c72859b
Compare
t-kikuc
approved these changes
Feb 26, 2025
Member
Author
|
@t-kikuc OK, changed PR title |
Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com>
Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com>
Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com>
c72859b to
4c2914f
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
as title.
Also, I checked the plan is working with the patch below.
patch
Why we need it:
I want to rewrite some methods to execute the plan.
Which issue(s) this PR fixes:
Part of #4980 #5006
Does this PR introduce a user-facing change?: