Change fields on deployment trace model to be not required#5619
Merged
khanhtc1202 merged 2 commits intomasterfrom Mar 4, 2025
Merged
Change fields on deployment trace model to be not required#5619khanhtc1202 merged 2 commits intomasterfrom
khanhtc1202 merged 2 commits intomasterfrom
Conversation
Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5619 +/- ##
=======================================
Coverage 26.57% 26.57%
=======================================
Files 475 475
Lines 50592 50592
=======================================
+ Hits 13444 13447 +3
+ Misses 36085 36083 -2
+ Partials 1063 1062 -1 ☔ View full report in Codecov by Sentry. |
Member
Author
|
@Warashi please reapprove, I updated the lint failure |
Warashi
approved these changes
Mar 4, 2025
ffjlabo
approved these changes
Mar 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Mark title and auth field in deployment trace model as not required
Why we need it:
We changed our thoughts on the required field in the deployment trace model. Users are not required to submit all the commit info in order to use the deployment trace feature
Which issue(s) this PR fixes:
Follow #5580
Does this PR introduce a user-facing change?: