Remove deprecated ReportEventHandled rpc from piped API#5620
Merged
khanhtc1202 merged 2 commits intomasterfrom Mar 4, 2025
Merged
Remove deprecated ReportEventHandled rpc from piped API#5620khanhtc1202 merged 2 commits intomasterfrom
khanhtc1202 merged 2 commits intomasterfrom
Conversation
Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5620 +/- ##
==========================================
+ Coverage 26.56% 26.57% +0.01%
==========================================
Files 475 475
Lines 50592 50582 -10
==========================================
+ Hits 13438 13444 +6
+ Misses 36091 36075 -16
Partials 1063 1063 ☔ View full report in Codecov by Sentry. |
Warashi
reviewed
Mar 4, 2025
Member
Warashi
left a comment
There was a problem hiding this comment.
I found the definitions of request/response messages remain.
Please remove them.
pipecd/pkg/app/server/service/pipedservice/service.proto
Lines 476 to 481 in 771da47
Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>
Member
Author
t-kikuc
approved these changes
Mar 4, 2025
Member
t-kikuc
left a comment
There was a problem hiding this comment.
I confirmed that ReportEventsHandled() is not called anywhere.
What "old Piped" means is unclear 😓
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
as title
Why we need it:
This RPC is no more used by piped(s) from 3 years ago 👴
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: