Implement ListDeploymentTrace rpc for Web#5631
Conversation
Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>
| string commit_url = 5 [(validate.rules).string.min_len = 1]; | ||
| int64 commit_timestamp = 6 [(validate.rules).int64.gte = 0]; | ||
| string author = 7; | ||
| string project_id = 2 [(validate.rules).string.min_len = 1]; |
There was a problem hiding this comment.
Need this due to deployment trace model is under project scope
Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5631 +/- ##
==========================================
+ Coverage 26.58% 26.62% +0.04%
==========================================
Files 477 478 +1
Lines 50657 50802 +145
==========================================
+ Hits 13465 13526 +61
- Misses 36134 36209 +75
- Partials 1058 1067 +9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| }, | ||
| Cursor: "cursor", | ||
| } | ||
| deployments, _, err := a.deploymentStore.List(ctx, opts) |
There was a problem hiding this comment.
I understand that this is like an N+1 query, but pageSize will reduce the problem.
There was a problem hiding this comment.
Yes, it is. I thought of making list deployment based on deployment trace commit hash rpc independently but maybe it's just over killed. So let's make this for now, if we need that when we faced a performance issue or such, we will implement that later 👍
3 participants
What this PR does:
Implementation for ListDeploymentTrace rpc for web client.
Why we need it:
Which issue(s) this PR fixes:
Part of #5444
Does this PR introduce a user-facing change?: