[SDK] Implement ListStageCommands() in SDK#5639
Merged
Conversation
Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Member
Author
|
We'll update the version of Go in another PR soon before merging the PR. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5639 +/- ##
==========================================
- Coverage 26.68% 25.43% -1.26%
==========================================
Files 477 477
Lines 50777 50844 +67
==========================================
- Hits 13552 12931 -621
- Misses 36156 36908 +752
+ Partials 1069 1005 -64 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Warashi
reviewed
Mar 10, 2025
Member
Warashi
left a comment
There was a problem hiding this comment.
Thank you!
I commented on comments and namings.
| } | ||
| } | ||
|
|
||
| type StageCommand struct { |
Member
There was a problem hiding this comment.
Could you please add comments as others?
Comment on lines
+699
to
+702
| const ( | ||
| CommandType_APPROVE_STAGE CommandType = iota | ||
| CommandType_SKIP_STAGE | ||
| ) |
Member
There was a problem hiding this comment.
We use PascalCase for naming.
Suggested change
| const ( | |
| CommandType_APPROVE_STAGE CommandType = iota | |
| CommandType_SKIP_STAGE | |
| ) | |
| const ( | |
| CommandTypeApproveStage CommandType = iota | |
| CommandTypeSkipStage | |
| ) |
Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Member
Author
|
@khanhtc1202 Sorry, please approve again 🙏 I fixed nits |
Merged
This was referenced Jul 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
as title
Why we need it:
Enable handling commands without polling by a plugin developer
Which issue(s) this PR fixes:
Part of #5367
Example Usage
Approval:
Skip:
(cf.
pipecd/pkg/app/piped/executor/analysis/analysis.go
Lines 103 to 126 in 0a5f895
Does this PR introduce a user-facing change?: