Merged
Conversation
Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5641 +/- ##
==========================================
- Coverage 26.68% 25.45% -1.24%
==========================================
Files 477 477
Lines 50777 50799 +22
==========================================
- Hits 13552 12931 -621
- Misses 36156 36863 +707
+ Partials 1069 1005 -64 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
Warashi
commented
Mar 10, 2025
| for _, p := range proposals { | ||
| fmt.Fprintf(&b, "\n") | ||
| fmt.Fprintf(&b, p.ReleaseNote) | ||
| fmt.Fprint(&b, p.ReleaseNote) |
Member
Author
There was a problem hiding this comment.
I updated here because the error below occurred
Error: ./comment.go:49:19: non-constant format string in call to fmt.Fprintf
t-kikuc
approved these changes
Mar 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
as title
Why we need it:
because 1.22 is EOL
Which issue(s) this PR fixes:
Fixes #5640
After merging this PR, I'll update the codegen image in the MakefileI'll send another PR to update the codegen's go version to pass the CI.
→ DONE
Does this PR introduce a user-facing change?: No