Skip to content

Rename PipedServiceClient to PluginServiceClient#5643

Merged
t-kikuc merged 1 commit intomasterfrom
plugin/rename-to-pluginservice
Mar 11, 2025
Merged

Rename PipedServiceClient to PluginServiceClient#5643
t-kikuc merged 1 commit intomasterfrom
plugin/rename-to-pluginservice

Conversation

@t-kikuc
Copy link
Member

@t-kikuc t-kikuc commented Mar 10, 2025

What this PR does:

as title

Why we need it:

just for clarification.

If we also want to rename the package pipedservice & pipedapi, let's do it in another PR.

Which issue(s) this PR fixes:

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

Signed-off-by: t-kikuc <tkikuchi07f@gmail.com>
Copy link
Member

@ffjlabo ffjlabo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@codecov
Copy link

codecov bot commented Mar 10, 2025

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 25.43%. Comparing base (0a5f895) to head (81e66a3).
Report is 7 commits behind head on master.

Files with missing lines Patch % Lines
pkg/plugin/pipedapi/client.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5643      +/-   ##
==========================================
- Coverage   26.68%   25.43%   -1.26%     
==========================================
  Files         477      477              
  Lines       50777    50844      +67     
==========================================
- Hits        13552    12931     -621     
- Misses      36156    36908     +752     
+ Partials     1069     1005      -64     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@t-kikuc t-kikuc enabled auto-merge (squash) March 10, 2025 09:19
Copy link
Member

@Warashi Warashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@t-kikuc t-kikuc merged commit 1622aee into master Mar 11, 2025
16 of 18 checks passed
@t-kikuc t-kikuc deleted the plugin/rename-to-pluginservice branch March 11, 2025 00:09
@github-actions github-actions bot mentioned this pull request Mar 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants