[SDK] Implement DetermineVersions RPC for DeploymentPlugin#5647
Merged
[SDK] Implement DetermineVersions RPC for DeploymentPlugin#5647
Conversation
…ioning Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
…se types Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
…rsionsResponse to internal models Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
Member
|
@Warashi Can you check the test result? It seems failed. |
Member
Author
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5647 +/- ##
==========================================
+ Coverage 25.53% 25.55% +0.01%
==========================================
Files 477 477
Lines 51022 51072 +50
==========================================
+ Hits 13030 13052 +22
- Misses 36987 37014 +27
- Partials 1005 1006 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
This PR implements the DetermineVersions gRPC method for DeploymentPlugin.
Why we need it:
To implement SDK
Which issue(s) this PR fixes:
Part of #5530
Does this PR introduce a user-facing change?: No