Update pipedv1 trigger to support adding trace commit hash to deployment model#5649
Merged
khanhtc1202 merged 1 commit intomasterfrom Mar 12, 2025
Merged
Update pipedv1 trigger to support adding trace commit hash to deployment model#5649khanhtc1202 merged 1 commit intomasterfrom
khanhtc1202 merged 1 commit intomasterfrom
Conversation
…ent model Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>
ffjlabo
approved these changes
Mar 12, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5649 +/- ##
==========================================
+ Coverage 25.54% 25.57% +0.02%
==========================================
Files 477 477
Lines 50945 51074 +129
==========================================
+ Hits 13016 13060 +44
- Misses 36924 37009 +85
Partials 1005 1005 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
as title
Why we need it:
We must pass this value to the deployment model to use the Deployment Trace feature. This change is the same as we did in pipedv0 logic (ref: pipedv0/trigger/deployment)
Which issue(s) this PR fixes:
Follow #5625
Does this PR introduce a user-facing change?: