Skip to content

Update pipedv1 trigger to support adding trace commit hash to deployment model#5649

Merged
khanhtc1202 merged 1 commit intomasterfrom
pipedv1-eventwatcher-trace
Mar 12, 2025
Merged

Update pipedv1 trigger to support adding trace commit hash to deployment model#5649
khanhtc1202 merged 1 commit intomasterfrom
pipedv1-eventwatcher-trace

Conversation

@khanhtc1202
Copy link
Member

@khanhtc1202 khanhtc1202 commented Mar 12, 2025

What this PR does:

as title

Why we need it:

We must pass this value to the deployment model to use the Deployment Trace feature. This change is the same as we did in pipedv0 logic (ref: pipedv0/trigger/deployment)

Which issue(s) this PR fixes:

Follow #5625

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

…ent model

Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>
Copy link
Member

@Warashi Warashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@khanhtc1202 khanhtc1202 merged commit 16089a9 into master Mar 12, 2025
16 checks passed
@khanhtc1202 khanhtc1202 deleted the pipedv1-eventwatcher-trace branch March 12, 2025 08:29
@codecov
Copy link

codecov bot commented Mar 12, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 25.57%. Comparing base (bc1a61b) to head (ecd6776).
Report is 7 commits behind head on master.

Files with missing lines Patch % Lines
pkg/app/pipedv1/trigger/deployment.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5649      +/-   ##
==========================================
+ Coverage   25.54%   25.57%   +0.02%     
==========================================
  Files         477      477              
  Lines       50945    51074     +129     
==========================================
+ Hits        13016    13060      +44     
- Misses      36924    37009      +85     
  Partials     1005     1005              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions github-actions bot mentioned this pull request Mar 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants