Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5657 +/- ##
==========================================
- Coverage 25.55% 25.54% -0.02%
==========================================
Files 477 477
Lines 51101 51129 +28
==========================================
Hits 13060 13060
- Misses 37036 37064 +28
Partials 1005 1005 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Warashi
left a comment
There was a problem hiding this comment.
Thank you!
I commented on logging.
| func (p *Plugin) DetermineVersions(context.Context, *sdk.ConfigNone, *sdk.Client, *sdk.DetermineVersionsInput) (*sdk.DetermineVersionsResponse, error) { | ||
| return &sdk.DetermineVersionsResponse{}, nil | ||
| func (p *Plugin) DetermineVersions(ctx context.Context, _ *sdk.ConfigNone, _ *sdk.Client, input *sdk.DetermineVersionsInput) (*sdk.DetermineVersionsResponse, error) { | ||
| lp := input.Client.LogPersister() |
There was a problem hiding this comment.
We cannot use LogPersister for anything other than ExecuteStage.
We have to use input.Logger instead.
pipecd/pkg/plugin/sdk/client.go
Lines 163 to 166 in d50a676
Warashi
left a comment
There was a problem hiding this comment.
Almost LGTM
I commented on nits
| "github.com/pipe-cd/pipecd/pkg/app/pipedv1/plugin/kubernetes/toolregistry" | ||
| config "github.com/pipe-cd/pipecd/pkg/configv1" | ||
| "github.com/pipe-cd/pipecd/pkg/plugin/sdk" | ||
| "go.uber.org/zap" |
There was a problem hiding this comment.
Please move this import to before the imports like github.com/pipe-cd/pipecd/**
Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com>
Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com>
Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com>
743bbd3 to
7d8e4a2
Compare
What this PR does:
I implemented k8s DetermineVersion by using SDK.
Why we need it:
We want to implement plugins with SDK.
Which issue(s) this PR fixes:
Part of #4980 #5006
Does this PR introduce a user-facing change?: