Skip to content

Fix Ui Deployment tracing with real api deployment traces#5660

Merged
khanhtc1202 merged 1 commit intomasterfrom
fix/deploy-tracing-ui
Mar 14, 2025
Merged

Fix Ui Deployment tracing with real api deployment traces#5660
khanhtc1202 merged 1 commit intomasterfrom
fix/deploy-tracing-ui

Conversation

@hongky-1994
Copy link
Contributor

What this PR does:

  • Fix timestamp of deployment trace need * 1000 before convert.
  • Add place holder "No deployment triggered" when no deployment

Why we need it:

Which issue(s) this PR fixes:

Part of #5444

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

- Fix wrong timestamp of deployment trace
- Add place holder "No deployment triggered" when no deployment

Signed-off-by: kypham <hongkyhvnh@gmail.com>
@codecov
Copy link

codecov bot commented Mar 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 25.54%. Comparing base (358d1b3) to head (a56be36).
Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5660   +/-   ##
=======================================
  Coverage   25.54%   25.54%           
=======================================
  Files         477      477           
  Lines       51129    51129           
=======================================
  Hits        13060    13060           
  Misses      37064    37064           
  Partials     1005     1005           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Member

@khanhtc1202 khanhtc1202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@khanhtc1202 khanhtc1202 enabled auto-merge (squash) March 14, 2025 03:31
Copy link
Member

@Warashi Warashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@khanhtc1202 khanhtc1202 merged commit 3fee44b into master Mar 14, 2025
18 checks passed
@khanhtc1202 khanhtc1202 deleted the fix/deploy-tracing-ui branch March 14, 2025 04:07
@github-actions github-actions bot mentioned this pull request Mar 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants