Skip to content

Fix redirect login page when logout, and applications page when login#5661

Merged
khanhtc1202 merged 1 commit intomasterfrom
fix/router-redirect
Mar 14, 2025
Merged

Fix redirect login page when logout, and applications page when login#5661
khanhtc1202 merged 1 commit intomasterfrom
fix/router-redirect

Conversation

@hongky-1994
Copy link
Contributor

What this PR does:

  • Redirect to Login page when user is not logged in and No routes matched url location.
  • Redirect to Application page when user is logged in and No routes matched url location

Why we need it:

Which issue(s) this PR fixes:

  • None

Does this PR introduce a user-facing change?: none

  • How are users affected by this change: none
  • Is this breaking change:
  • How to migrate (if breaking change):

@codecov
Copy link

codecov bot commented Mar 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 25.54%. Comparing base (358d1b3) to head (0457b92).
Report is 188 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5661   +/-   ##
=======================================
  Coverage   25.54%   25.54%           
=======================================
  Files         477      477           
  Lines       51129    51129           
=======================================
  Hits        13060    13060           
  Misses      37064    37064           
  Partials     1005     1005           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@khanhtc1202 khanhtc1202 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@khanhtc1202 khanhtc1202 enabled auto-merge (squash) March 14, 2025 03:30
Copy link
Member

@Warashi Warashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@khanhtc1202 khanhtc1202 merged commit ddfc039 into master Mar 14, 2025
18 checks passed
@khanhtc1202 khanhtc1202 deleted the fix/router-redirect branch March 14, 2025 04:07
@khanhtc1202 khanhtc1202 moved this to Done in v0.50.3 Mar 14, 2025
@khanhtc1202 khanhtc1202 removed this from v0.50.3 Mar 25, 2025
@khanhtc1202 khanhtc1202 moved this to Done in v0.51.0 Mar 25, 2025
@github-actions github-actions bot mentioned this pull request Mar 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants