Enhance GetLivestateRequest with additional application details#5669
Merged
Enhance GetLivestateRequest with additional application details#5669
Conversation
Updated the GetLivestateRequest to include PipedId, ApplicationName, and DeployTargets for improved context in the livestate reporting process. Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5669 +/- ##
=======================================
Coverage 25.57% 25.58%
=======================================
Files 478 478
Lines 51240 51243 +3
=======================================
+ Hits 13105 13108 +3
Misses 37130 37130
Partials 1005 1005 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
t-kikuc
approved these changes
Mar 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Updated the GetLivestateRequest to include PipedId, ApplicationName, and DeployTargets for improved context in the livestate reporting process.
Why we need it:
We need these to implement livestate/driftdetection feature
Which issue(s) this PR fixes:
Follows #5668
Part of #4980 #5363
Does this PR introduce a user-facing change?: No