Skip to content

Refactor k8s plugin logic#5678

Merged
ffjlabo merged 6 commits intomasterfrom
split-k8s-plugin-logic
Mar 18, 2025
Merged

Refactor k8s plugin logic#5678
ffjlabo merged 6 commits intomasterfrom
split-k8s-plugin-logic

Conversation

@ffjlabo
Copy link
Member

@ffjlabo ffjlabo commented Mar 18, 2025

What this PR does:

as title

fixes

Why we need it:

We want to implement plugins with SDK.

Which issue(s) this PR fixes:

Part of #4980 #5006

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

ffjlabo added 6 commits March 18, 2025 15:16
Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com>
Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com>
Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com>
Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com>
Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com>
Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com>
@codecov
Copy link

codecov bot commented Mar 18, 2025

Codecov Report

Attention: Patch coverage is 37.62887% with 121 lines in your changes missing coverage. Please review.

Project coverage is 25.66%. Comparing base (57c48c1) to head (e4b3347).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...p/pipedv1/plugin/kubernetes/deployment/rollback.go 0.00% 71 Missing ⚠️
...g/app/pipedv1/plugin/kubernetes/deployment/sync.go 59.13% 37 Missing and 10 partials ⚠️
...app/pipedv1/plugin/kubernetes/deployment/plugin.go 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5678      +/-   ##
==========================================
- Coverage   25.66%   25.66%   -0.01%     
==========================================
  Files         474      476       +2     
  Lines       50905    50894      -11     
==========================================
- Hits        13066    13063       -3     
+ Misses      36848    36841       -7     
+ Partials      991      990       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ffjlabo ffjlabo marked this pull request as ready for review March 18, 2025 07:36
@ffjlabo ffjlabo enabled auto-merge (squash) March 18, 2025 07:36
Copy link
Member

@Warashi Warashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@ffjlabo ffjlabo merged commit 7a07070 into master Mar 18, 2025
18 checks passed
@ffjlabo ffjlabo deleted the split-k8s-plugin-logic branch March 18, 2025 08:36
@github-actions github-actions bot mentioned this pull request Mar 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants