Skip to content

Add application livestate version in livestatereporter for pipedv1#5682

Merged
ffjlabo merged 1 commit intomasterfrom
add-application-livestate-version
Mar 19, 2025
Merged

Add application livestate version in livestatereporter for pipedv1#5682
ffjlabo merged 1 commit intomasterfrom
add-application-livestate-version

Conversation

@ffjlabo
Copy link
Member

@ffjlabo ffjlabo commented Mar 19, 2025

What this PR does:

as title.
It is required for the pipedv0, especially k8s. It is used to update livestate by using the diff from an older version.
Currently, the logic is used only for k8s livestate, and the others are not considered it.

https://github.com/pipe-cd/pipecd/blob/7a07070328e3d36a70c303f3f0c6a9b1f6076cfc/pkg/app/server/applicationlivestatestore/store.go#L93C1-L130C2

Why we need it:

Currently, we don't use it after pipedv1, but we use it in the Control Plane to update k8s livestate for apps managed by pipedv0.
So just added to pass the validation.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com>
@codecov
Copy link

codecov bot commented Mar 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 25.67%. Comparing base (57c48c1) to head (99da0c9).
Report is 3 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5682   +/-   ##
=======================================
  Coverage   25.66%   25.67%           
=======================================
  Files         474      476    +2     
  Lines       50905    50897    -8     
=======================================
  Hits        13066    13066           
+ Misses      36848    36841    -7     
+ Partials      991      990    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ffjlabo ffjlabo marked this pull request as ready for review March 19, 2025 02:05
@ffjlabo ffjlabo enabled auto-merge (squash) March 19, 2025 02:05
Copy link
Member

@Warashi Warashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

We can choose a method that removes the validation, but I think it's better to leave the timestamp field so we can see how old the live state is.

@ffjlabo ffjlabo merged commit f51a364 into master Mar 19, 2025
18 checks passed
@ffjlabo ffjlabo deleted the add-application-livestate-version branch March 19, 2025 05:49
@github-actions github-actions bot mentioned this pull request Mar 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants