Add application livestate version in livestatereporter for pipedv1#5682
Merged
Add application livestate version in livestatereporter for pipedv1#5682
Conversation
Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5682 +/- ##
=======================================
Coverage 25.66% 25.67%
=======================================
Files 474 476 +2
Lines 50905 50897 -8
=======================================
Hits 13066 13066
+ Misses 36848 36841 -7
+ Partials 991 990 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Warashi
approved these changes
Mar 19, 2025
Member
Warashi
left a comment
There was a problem hiding this comment.
LGTM
We can choose a method that removes the validation, but I think it's better to leave the timestamp field so we can see how old the live state is.
t-kikuc
approved these changes
Mar 19, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
as title.
It is required for the pipedv0, especially k8s. It is used to update livestate by using the diff from an older version.
Currently, the logic is used only for k8s livestate, and the others are not considered it.
https://github.com/pipe-cd/pipecd/blob/7a07070328e3d36a70c303f3f0c6a9b1f6076cfc/pkg/app/server/applicationlivestatestore/store.go#L93C1-L130C2
Why we need it:
Currently, we don't use it after pipedv1, but we use it in the Control Plane to update k8s livestate for apps managed by pipedv0.
So just added to pass the validation.
Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?: