Skip to content

[K8s Plugin] Add e2e tests for K8S_ROLLBACK stage and fix the bug#5683

Merged
Warashi merged 1 commit intomasterfrom
k8s-plugin-rollback-e2e-tests
Mar 19, 2025
Merged

[K8s Plugin] Add e2e tests for K8S_ROLLBACK stage and fix the bug#5683
Warashi merged 1 commit intomasterfrom
k8s-plugin-rollback-e2e-tests

Conversation

@Warashi
Copy link
Member

@Warashi Warashi commented Mar 19, 2025

What this PR does:

  • add simple E2E test for K8S_ROLLBACK stage
  • add a variant label to manifests when executing the K8S_ROLLBACK stage
    • to make consistent with the K8S_SYNC stage

Why we need it:

  • to check and keep the k8s plugin's behavior as the test

Which issue(s) this PR fixes:

Part of #4980

Does this PR introduce a user-facing change?: No

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
@codecov
Copy link

codecov bot commented Mar 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 25.75%. Comparing base (2aa01ac) to head (52cdd4a).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5683      +/-   ##
==========================================
+ Coverage   25.66%   25.75%   +0.08%     
==========================================
  Files         476      476              
  Lines       50894    50900       +6     
==========================================
+ Hits        13063    13109      +46     
+ Misses      36841    36794      -47     
- Partials      990      997       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Warashi Warashi marked this pull request as ready for review March 19, 2025 06:19
Copy link
Member

@t-kikuc t-kikuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

If needed in the future, let's find a way to split simple unit tests and e2e tests for faster testing.

@Warashi Warashi enabled auto-merge (squash) March 19, 2025 06:28
Copy link
Member

@ffjlabo ffjlabo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Warashi Warashi merged commit 8e71ecd into master Mar 19, 2025
18 checks passed
@Warashi Warashi deleted the k8s-plugin-rollback-e2e-tests branch March 19, 2025 06:44
@github-actions github-actions bot mentioned this pull request Mar 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants