[K8s Plugin] Add e2e tests for K8S_ROLLBACK stage and fix the bug#5683
Merged
[K8s Plugin] Add e2e tests for K8S_ROLLBACK stage and fix the bug#5683
Conversation
Signed-off-by: Shinnosuke Sawada-Dazai <shin@warashi.dev>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5683 +/- ##
==========================================
+ Coverage 25.66% 25.75% +0.08%
==========================================
Files 476 476
Lines 50894 50900 +6
==========================================
+ Hits 13063 13109 +46
+ Misses 36841 36794 -47
- Partials 990 997 +7 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
t-kikuc
approved these changes
Mar 19, 2025
Member
t-kikuc
left a comment
There was a problem hiding this comment.
LGTM
If needed in the future, let's find a way to split simple unit tests and e2e tests for faster testing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Why we need it:
Which issue(s) this PR fixes:
Part of #4980
Does this PR introduce a user-facing change?: No