Skip to content

Enable livestate reporter for pipedv1#5691

Merged
ffjlabo merged 1 commit intomasterfrom
enable-livestate-reporter-for-pipedv1
Mar 25, 2025
Merged

Enable livestate reporter for pipedv1#5691
ffjlabo merged 1 commit intomasterfrom
enable-livestate-reporter-for-pipedv1

Conversation

@ffjlabo
Copy link
Member

@ffjlabo ffjlabo commented Mar 25, 2025

What this PR does:

as title

Why we need it:

We need it to send the livestate for the app managed by pipedv1.

Which issue(s) this PR fixes:

Part of #5363

Does this PR introduce a user-facing change?:

  • How are users affected by this change:
  • Is this breaking change:
  • How to migrate (if breaking change):

Signed-off-by: Yoshiki Fujikane <ffjlabo@gmail.com>
@codecov
Copy link

codecov bot commented Mar 25, 2025

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 25.77%. Comparing base (5079ca7) to head (2b58ac9).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
pkg/app/pipedv1/cmd/piped/piped.go 0.00% 8 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5691   +/-   ##
=======================================
  Coverage   25.76%   25.77%           
=======================================
  Files         476      476           
  Lines       50976    50984    +8     
=======================================
+ Hits        13135    13141    +6     
- Misses      36843    36845    +2     
  Partials      998      998           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ffjlabo ffjlabo marked this pull request as ready for review March 25, 2025 01:44
@ffjlabo ffjlabo enabled auto-merge (squash) March 25, 2025 01:44
Copy link
Member

@Warashi Warashi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@ffjlabo ffjlabo merged commit 9ad138a into master Mar 25, 2025
17 of 18 checks passed
@ffjlabo ffjlabo deleted the enable-livestate-reporter-for-pipedv1 branch March 25, 2025 04:43
@github-actions github-actions bot mentioned this pull request Mar 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants