-
Notifications
You must be signed in to change notification settings - Fork 208
Refactor Codegen Dockerfile #6402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Junya Okabe <junya.okabe.ig@gmail.com>
khanhtc1202
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great improvement, thanks 👍
|
Note: Try re-gen the new container image on CI after this been merged |
|
@Okabe-Junya Tested on my local and look like the built container image missed some protoc lib. After I fixed the missing lib issue, it turned out we need to use the go command for mockgen 😓 So basically we need to use a Go container image for this codegen process (or have to find a way to separate protoc and mock into 2 different codegen images). I will revert the commit till we find a way for better codegen image (as you pointed out) |
This reverts commit 60636fb.
This reverts commit 60636fb. Signed-off-by: khanhtc1202 <khanhtc1202@gmail.com>
What this PR does:
golang:1.25.2todebian:bookworm-slimWhy we need it:
Which issue(s) this PR fixes:
cf. #6379 (review)
Does this PR introduce a user-facing change?: