[Multi_K8s-Plugin] Fix DetermineStrategy to be multi-target aware#6672
Open
mohammedfirdouss wants to merge 1 commit intopipe-cd:masterfrom
Open
[Multi_K8s-Plugin] Fix DetermineStrategy to be multi-target aware#6672mohammedfirdouss wants to merge 1 commit intopipe-cd:masterfrom
mohammedfirdouss wants to merge 1 commit intopipe-cd:masterfrom
Conversation
Signed-off-by: Mohammed Firdous <124298708+mohammedfirdouss@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Makes
DetermineStrategyandDetermineVersionsin thekubernetes_multiclusterplugin aware of per-cluster manifest overrides (multiTargets). Previously both functions passed an emptyKubernetesMultiTarget{}when loading manifests, so per-target manifest paths were silently ignored when deciding whether a deployment required progressive delivery.Why we need it:
When a user configures different manifest paths per cluster (e.g.
./cluster-usand./cluster-eu), a change only to one cluster'sdeployment.yamlwould not triggerPipelineSync— the strategy check was loading from the app-level manifest path and missing the per-target change entirely. This could cause a workload update to be deployed via QuickSync, bypassing canary and baseline stages completely.Which issue(s) this PR fixes:
Fixes #6446
Does this PR introduce a user-facing change?:
DetermineStrategynow correctly triggersPipelineSyncwhen a workload change is made to any configuredmultiTarget, even if the app-level manifests are unchanged.