[Multi_K8s-Plugin] Fix livestate drift detection and resource filtering#6673
Open
mohammedfirdouss wants to merge 2 commits intopipe-cd:masterfrom
Open
[Multi_K8s-Plugin] Fix livestate drift detection and resource filtering#6673mohammedfirdouss wants to merge 2 commits intopipe-cd:masterfrom
mohammedfirdouss wants to merge 2 commits intopipe-cd:masterfrom
Conversation
…ce filtering Signed-off-by: Mohammed Firdous <124298708+mohammedfirdouss@users.noreply.github.com>
Signed-off-by: Mohammed Firdous <124298708+mohammedfirdouss@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Implements two missing livestate features in the
kubernetes_multiclusterplugin, porting them from the single-clusterkubernetesplugin:pipecd.dev/ignore-drift-detection: "true"are now excluded from drift comparison, matching the behaviour of the single-cluster plugin.appStateInformer.includeResourcesandappStateInformer.excludeResourcesto control which resource types are included in the livestate drift check.Why we need it:
Without drift detection ignore, applications with resources that are expected to drift at runtime (e.g. HPAs, Jobs managed by external controllers) would always show as
OutOfSyncin the PipeCD UI, even when everything is working correctly. Without include/exclude filtering, there was no way to scope the drift check to the resource types that matter for a given deploy target.Which issue(s) this PR fixes:
Fixes #6446
Does this PR introduce a user-facing change?:
pipecd.dev/ignore-drift-detection: "true"to exclude them from drift detection. Users can also configureappStateInformer.includeResourcesandappStateInformer.excludeResourcesper deploy target to scope the livestate comparison.