[Multi_K8s-Plugin] Support per-target kustomizeDir#6718
Open
mohammedfirdouss wants to merge 2 commits intopipe-cd:masterfrom
Open
[Multi_K8s-Plugin] Support per-target kustomizeDir#6718mohammedfirdouss wants to merge 2 commits intopipe-cd:masterfrom
mohammedfirdouss wants to merge 2 commits intopipe-cd:masterfrom
Conversation
Signed-off-by: Mohammed Firdous <124298708+mohammedfirdouss@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Implements support for the
kustomizeDirfield onKubernetesMultiTarget, which was defined in the config struct and documented inRFC-0014but never wired up to the manifest loader.Before this change, the
kustomizeDirfield was silently ignored and users with multi-target Kustomize overlays in per-cluster subdirectories would never have their kustomization files detected or used.Why we need it:
Without this fix, any multi-target app relying on per-target Kustomize overlays (e.g.
cluster-us/kustomization.yaml) would fall back to plain YAML loading silently, producing incorrect manifests with no error.Which issue(s) this PR fixes:
Part of #6446
Does this PR introduce a user-facing change?:
kustomizeDirset per target now correctly detect and run kustomize from that subdirectory instead of the root app directory.