Fix: Orphaned process and goroutine leak in ScriptRun/CustomSync leading to split-brain deployments#6735
Open
pulkitvats2007-crypto wants to merge 1 commit intopipe-cd:masterfrom
Conversation
Signed-off-by: pulkitvats2007-crypto <pulkitvats2007@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
exec.CommandContext.cmd.WaitDelay = time.Secondto prevent hangs caused by inherited pipes from background shell jobs.TestExecuteCommandCancellation) to verify proper cancellation behavior and prevent regressions.Why we need it:
Which issue(s) this PR fixes:
Fixes #6734
Does this PR introduce a user-facing change?:
No
How are users affected by this change:
Is this breaking change:
How to migrate (if breaking change):