#6765 issue is fixed Added Dark Mode Support and Theming Consistency#6771
Open
AbhiramDhanvi wants to merge 1 commit into
Open
#6765 issue is fixed Added Dark Mode Support and Theming Consistency#6771AbhiramDhanvi wants to merge 1 commit into
AbhiramDhanvi wants to merge 1 commit into
Conversation
AbhiramDhanvi
requested review from
Warashi,
ffjlabo,
hongky-1994 and
khanhtc1202
Contributor
Ayushmore1214
left a comment
Ayushmore1214
left a comment
There was a problem hiding this comment.
@AbhiramDhanvi thanks for your contribution, plz start with assigning of issues first to you and then start working on it, we might have to close this one as there is already one relevant PR #6766 here
Contributor
|
@AbhiramDhanvi also your DCO seems to be failing plz sign it off |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
Adds full dark mode support to the PipeCD web application. I've added a simple theme context to handle switching, updated the main entry point to watch for OS preference or saved settings, and added a sun/moon toggle button directly in the header so users can switch themes easily.
Why we need it:
The application currently only supports a bright light theme, which can cause eye strain. Adding a dark mode provides a better, more modern user experience and respects user preferences.
Which issue(s) this PR fixes:
Fixes #6765
Does this PR introduce a user-facing change:
Yes.
How are users affected by this change:
Users will notice a new sun or moon icon in the top right of the header bar. Clicking it flips the entire app between light and dark themes. The app will also automatically start in dark mode if their computer is set to dark mode by default.
Is this breaking change:
No.
How to migrate (if breaking change):
N/A