feat: configurable tests path and sha-tagged release#2
Merged
hbahadorzadeh merged 4 commits intomainfrom Apr 26, 2026
Merged
Conversation
- Add tests_path input: path passed to pytest (directory, file, nodeids); defaults to project_path - Use INPUT_TESTS_PATH in step-test.sh instead of always running pytest on project root - Record sha-<short> in the JSONL release log for traceability (PyPI has no dist-tag equivalent) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
There was a problem hiding this comment.
Code Review
This pull request introduces a new tests_path input for the test step, allowing users to specify directories or files for pytest, and adds the git commit SHA to the release logs for improved traceability. Review feedback highlights a potential crash in step-release.sh due to an unbound GITHUB_SHA variable and recommends quoting TESTS_PATH in step-test.sh to correctly handle file paths containing spaces.
Replace the per-command psh check-and-wrap pattern with `#!/usr/bin/env psh` as the shebang so psh intercepts and logs every command in the script automatically. main.sh already invoked scripts directly so no change needed there. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…set -u Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tests_pathinput: path passed to pytest (directory, file, or node IDs); defaults toproject_pathsha-<shortsha>in the JSONL release log for traceability (PyPI has no dist-tag equivalent)Changes
action.ymltests_pathinput wired to test step viaINPUT_TESTS_PATHGITHUB_SHApassed to release stepsrc/step-test.shTESTS_PATHdefaults to$PROJECTwhenINPUT_TESTS_PATHis unset; otherwise uses the provided pathsrc/step-release.shsha-<shortsha>in the JSONL release event for downstream traceabilityTest plan
tests_path: tests/unit: pytest runs only againsttests/unit"sha":"abc1234"field🤖 Generated with Claude Code