feat(upgrade): upgrade handler for v1.2#511
Conversation
jdubpark
requested review from
0xHansLee,
LeoHChen,
edisonz0718,
gezerui0124,
limengformal and
ramtinms
as code owners
jdubpark
changed the title
jdubpark
changed the title
| ) | ||
|
|
||
| const ( | ||
| UpgradeName = "v1.2" |
| @@ -0,0 +1,49 @@ | |||
| //nolint:revive,stylecheck // versioning | |||
| package v_1_2 | |||
| AeneidUpgradeHeight = 10_000_000 | ||
| // StoryUpgradeHeight defines the block height at which the upgrade is triggered on Story. | ||
| StoryUpgradeHeight = 10_000_000 |
There was a problem hiding this comment.
Since single binary upgrade is not ready yet, do we want to hardcode the upgrade height?
There was a problem hiding this comment.
you're correct, we need to use the normal upgrade handler (I copied constants.go from virgil upgrade). Fixed in eff22af
| StoreUpgrades: storetypes.StoreUpgrades{}, | ||
| } | ||
|
|
||
| var Fork = upgrades.Fork{ |
There was a problem hiding this comment.
Same here. Do we want to use upgrade module only since single binary upgrade is not ready yet
0xHansLee
left a comment
0xHansLee
left a comment
There was a problem hiding this comment.
Need to add Upgrade and Fork to app/upgrades.go
|
|
||
| // Initial parameters. | ||
| InitialRefundFeeBps = 100 // 1% | ||
| InitialRefundPeriod = 7 * 24 * time.Hour // 7 days |
There was a problem hiding this comment.
qq. We want to set 7 days for initial refund period, not 1 day?
There was a problem hiding this comment.
right, I recall we talked about the parameter value. Changed to 1 day here d2404ff, please confirm that 1 day is the intended duration @gezerui0124 @edisonz0718
There was a problem hiding this comment.
And please check the refundFeeBps as well 🙏
0xHansLee
left a comment
0xHansLee
left a comment
There was a problem hiding this comment.
Please add Fork to app/upgrades/go#L23 as well. And also need to set upgrade height in scheduleForkUpgrade depending on the network and set schedule accordingly.
We plan to schedule the upgrade through the |
| StoreUpgrades: storetypes.StoreUpgrades{}, | ||
| } | ||
|
|
||
| var Fork = upgrades.Fork{ |
There was a problem hiding this comment.
Is Fork used anywhere for the upgrade?
|
|
||
| // Initial parameters. | ||
| InitialRefundFeeBps uint32 = 100 // 1% | ||
| InitialRefundPeriod time.Duration = 1 * 24 * time.Hour // 1 days |
upgrade handler to set new params for validator fallback (#484) in v1.2 issue: none
upgrade handler to set new params for validator fallback (#484) in v1.2 issue: none
4 participants
upgrade handler to set new params for validator fallback (#484) in v1.2
issue: none