Unable to set different CDN with `$.reel.cdn` #124

Closed
pisi opened this Issue May 8, 2012 · 2 comments

Comments

Projects
None yet
1 participant
@pisi
Owner

pisi commented May 8, 2012

Support issue #121 surfaced a fundamental problem with $.reel.cdn - it can not be customized. Paths to CDN-served resources are being resolved at the load time and are cached into local vars. That means any consequent $.reel.cdn changes hav no effect as the paths have already been resolved.

The CDN path insertion must not be pre-processed and must happen on the fly.

@pisi

This comment has been minimized.

Show comment
Hide comment
@pisi

pisi May 8, 2012

Owner

Now it works as expected. Can someone please verify?

Owner

pisi commented May 8, 2012

Now it works as expected. Can someone please verify?

@pisi

This comment has been minimized.

Show comment
Hide comment
@pisi

pisi May 21, 2012

Owner

This bugfix just landed in the v1.2rc2 heading for the 1.2 launch. If you can, please verify this bugfix is working for you. Thanks!

Owner

pisi commented May 21, 2012

This bugfix just landed in the v1.2rc2 heading for the 1.2 launch. If you can, please verify this bugfix is working for you. Thanks!

@pisi pisi closed this Jun 24, 2012

pisi added a commit that referenced this issue Jul 16, 2012

Reel 1.2
========

Lovely new features:
* in-picture annotations
* new image preloading method
* frame by frame stepping
* new data change model
* full documentation
* jQuery 1.5+

New options:
* `annotations`, `attr`, `cursor`, `steppable`, improved `images`

New events:
* `stepLeft`, `stepRight`, `openingDone`, improved `play`

New methods:
* `.unreel()`, improved `.reel()`

Includes fixes for issues #10, #20, #36, #51, #62, #64, #65, #69, #103, #110, #111, #113, #115, #117, #122, #124, #125, #126

Enjoy!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment