-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revised events namespace #64
Comments
After a careful inspection I found that namespaces are used correctly where they should be. That is on two occasions - (1) for internal binding to browser events (like mousemove) and (2) for the document-wide However a new bug was discovered during the testing concerning unbinding of preload IMGs |
pisi
added a commit
that referenced
this issue
Dec 30, 2011
Just missing annotations examples - the'll be in the beta. Changes: * Non-`wheelable` Reels now allow scrolling of the page when wheeling above the Reel instance. * New option `attr` allows to set custom attributes of the IMG tag (useful for re-using DOM nodes). * Instances being re-instantiated now perform automatic teardown (GH-62). * Proper image preload events unbinding on teardown (GH-64). * Option `scrollable` can disable page scrolling (if needed) on touch devices. * New event `"openingDone"` now announces the end of opening animation (GH-65). * Internal event `slide` renamed to `pan` (GH-51). * Actual frame number is manifested with a wrapper class name, e.g. `frame-8` (GH-69). * Improved order of preloaded images gradually increasing fidelity of the image, thus the name `"fidelity"` and this mode is now default. The former order is designated `"linear". Preloading mode is chosen by new `preload` option accepting a mode name. (GH-10). * Deprecated options `hotspot`, `tooltip` and `reversed` have been removed. * Bare click on left/right half of the image steps the Reel one frame forward/back. Set `steppable` to false to disable. Comes with `"stepLeft"` and `"stepRight"` events (GH-20). * Custom text/graphics can augment the frames using the brand new `annotations` feature (GH-36). * New complementary `.unreel()` function to revert effects of `.reel()` on the DOM. * Control event `play` now accepts optional `speed` parameter. * Mouse cursor is now customizable with the new `cursor` option. The new failsafe cursor is now `"move"`.
pisi
added a commit
that referenced
this issue
Jul 16, 2012
======== Lovely new features: * in-picture annotations * new image preloading method * frame by frame stepping * new data change model * full documentation * jQuery 1.5+ New options: * `annotations`, `attr`, `cursor`, `steppable`, improved `images` New events: * `stepLeft`, `stepRight`, `openingDone`, improved `play` New methods: * `.unreel()`, improved `.reel()` Includes fixes for issues #10, #20, #36, #51, #62, #64, #65, #69, #103, #110, #111, #113, #115, #117, #122, #124, #125, #126 Enjoy!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
We already have a
.reel
namespace for events and it currently is used on few occasions, but not for all. This is very inconsistent and should be fixed.The text was updated successfully, but these errors were encountered: