Internal ticker fail

[jessepinuelas]

I have implemented the reel and it is working great, but I have this problem I was hoping someone can assist me with. I click on a thumbnail and it displays my 360 in a modal and it works great. But when I close the modal and reopen it I can't seem to scrub or rotate the images again. It still works when I use my mouse wheel or my keyboard left and right button arrows which I have binder but the drag does not work after closing my modal and reopening it.

I was wondering if it had anything to do with the unbinding of events from the pool on line 438 or the teardown function on line 211. Any help would be greatly appreciated.

[sametjan]

If you clear out the $.reel.instances array, and then call reel on the element again, it will re-enable the drag.

[jessepinuelas]

Makes sense, the reel instance was not being reset.

[pisi]

@jessepinuelas did @merlin903's suggestion work for you?

I've put together a test case fiddle confirming everything you reported. I even included all known ways to "reset" Reel, but none of them does it. I followed my suspicion about ticker no being properly restarted when leader instance appears in the document again. So I configured some animation and added a ticker tracker, which plants ticks below the image. That confirmed that the ticker never resumes its operation when the modal is shown, hidden and shown again.

[pisi]

Some notes for me:

1. As the last Reel instance disappears from DOM, it correctly yields a null tempo, which in turn stops the ticker. However it doesn't clear the timeout id in the ticker private var. As there is another ticker local var inside the tick scope, the outer ticker is inaccessible for the clearing.
2. When the instance is removed abruptly by simply emptying its context, the now orphan DOM fragment is not removed from $.reel.instances jQuery and by being the oldest one, it takes the leader role, but with null tempo, which stops the ticker again.

[pisi]

It should be fixed now in the development branch. The working is backed up by tests, but still I updated the fiddle:

http://jsfiddle.net/FeeDy/3/

I removed the workaround attempts from there and made it link the development version code from github directly. Please confirm the new code is working well in the fiddle and also for you in your application.

[pisi]

@jessepinuelas, can you please confirm this issue you reported is gone from the current development branch?