feat: add custom formatURL support#4
Merged
pi0 merged 4 commits intopithings:mainfrom Apr 24, 2026
Merged
Conversation
Contributor
Author
|
📝 note: CI fixed with #5 😊 |
pi0
reviewed
Apr 22, 2026
| const baseUrl = new URL(`http://localhost:${actualPort}${basePath}/`); | ||
| if (handler.connectionToken) baseUrl.searchParams.set("tkn", handler.connectionToken); | ||
| if (opts.openFile) { | ||
| // VS Code's workbench reads `payload` as Map entries: new Map(JSON.parse(payload)). |
Member
There was a problem hiding this comment.
Wondering if it might be more useful to instead add a generic formatURL(url: URL): string | URL | undefined callback option that accepts original url and allows customizing it. I guess we might have more options than openFile
Contributor
Author
There was a problem hiding this comment.
Yes, that’s exactly what I thought after creating this PR, I’ve already seen other use cases 😅 I’ll have a look!
Contributor
Author
There was a problem hiding this comment.
@pi0 I've tried to make the function more generic so that we can add more options 😊
formatURL support
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
❓ Context
Adds a
formatURLcallback option tostartCodeServer/createCodeServer, allowing callers to customize the URL returned by the server before it is handed back to the consumer.The callback receives the base URL after auth params (
tkn) have been applied. It can return a modifiedURL, a plainstring, orundefined(keep the original URL unchanged).This replaces the previous
openFileoption with a more generic primitive — callers can now inject any URL parameter VS Code supports (payload,folder, etc.) without requiring dedicated options in coderaft itself.