Handle comma-separated filename inputs for Sonar issues JSON and Sonar hotspots JSON #365
Conversation
carlosu7
changed the title
drdavella
left a comment
drdavella
left a comment
There was a problem hiding this comment.
Looks good overall. Even though --sonar-hotspots-json is just a pass-thru without implementation I think we should also update the help message to indicate a comma-separated input.
framework/codemodder-base/src/main/java/io/codemodder/CodemodLoader.java
Outdated
Show resolved
Hide resolved
| } catch (IOException e) { | ||
| throw new UncheckedIOException("Problem reading Sonar issues JSON file", e); | ||
| } | ||
| if (issuesFiles != null) { |
There was a problem hiding this comment.
This code makes sense to me but I also want to be careful that we don't introduce any regressions here. Would you be able to add a unit test or do you feel like this is sufficiently covered by existing tests?
There was a problem hiding this comment.
@drdavella
When we run a codemod test that is not a sonar codemod, this sonar module is being executed because all modules (defectdojo, semgrep, codeql, sonar, etc) are being configured at CodemodLoader.java. So, in when the non-sonar codemod test is being executed, this sonar module handles the empty/null issuesFiles because they're not required for that codemod (defectdojo, semgrep, etc).
So yes, this case is already covered.
There was a problem hiding this comment.
@drdavella In this commit be04cc0 I have updated our tests to support multiple sonar issues json files and refactor one existing sonar test
|
| .collect(Collectors.toList()); | ||
|
|
||
| if (sonarJsonsPaths.isEmpty()) { | ||
| Path defaultPath = testResourceDir.resolve("sonar-issues.json"); |
There was a problem hiding this comment.
Sorry, I thought I left this comment before but I don't see it. Shouldn't it be this now?
| Path defaultPath = testResourceDir.resolve("sonar-issues.json"); | |
| Path defaultPath = testResourceDir.resolve("sonar-issues_1.json"); |
There was a problem hiding this comment.
@drdavella no, default sonar issues filename remains the same as it previously was, otherwise, i will have to rename all other sonar codemod test json files
There was a problem hiding this comment.
Oh okay, I'm sorry. I missed that the one you renamed was for a specific test.
2 participants
Issue: #364
Example of running a list of sonar findings files:
Sonar hotspot CLI input was the only update since there's no implementation for it yet