Skip to content

Add default value to Change.diffSide in CodeTF#240

Merged
drdavella merged 1 commit intomainfrom
update-codetfchange-diffside
Feb 6, 2024
Merged

Add default value to Change.diffSide in CodeTF#240
drdavella merged 1 commit intomainfrom
update-codetfchange-diffside

Conversation

@drdavella
Copy link
Copy Markdown
Member

@drdavella drdavella commented Feb 6, 2024

Overview

Add diffSide to Change entry in CodeTF

Description

  • The CodeTF spec now requires this field: Update spec to require diffSide for changes codemodder-specs#15
  • Since all of our descriptions and line numbers are currently phrased in terms of additive changes/modifications, we default to the RIGHT side of diffs
  • Eventually it may be useful to use LEFT for certain kinds of changes as well

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Feb 6, 2024

Quality Gate Failed Quality Gate failed

Failed conditions

4.0% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@drdavella drdavella added this pull request to the merge queue Feb 6, 2024
Merged via the queue into main with commit cccc8a7 Feb 6, 2024
@drdavella drdavella deleted the update-codetfchange-diffside branch February 6, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andrecsilva andrecsilva andrecsilva approved these changes

@clavedeluna clavedeluna Awaiting requested review from clavedeluna clavedeluna is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@drdavella @andrecsilva