Added support for multiple fixes per block in fix-file-resouce-leak#245
Added support for multiple fixes per block in fix-file-resouce-leak#245andrecsilva merged 2 commits intomainfrom
Conversation
| ) | ||
| # is closed? | ||
| name_condition = map( | ||
| # pylint: disable-next=cell-var-from-loop |
There was a problem hiding this comment.
hmmm either this pylint warning is worth listening to or it's a pylint bug? Either way, maybe a list-comp is easier to read here?
There was a problem hiding this comment.
I wanted to avoid building the list since the result would just be fed into all. I don't exactly remember the issue with the warning was. It may be invalid by now. I'll try to remove and see if it still complains.
clavedeluna
left a comment
clavedeluna
left a comment
There was a problem hiding this comment.
Personal preference nit pick would be to use less one-letter variable names as it's harder to grep for them .
andrecsilva
force-pushed
the
multi-fresource-leak
branch
from
4002e13 to
f549be1
Compare
| results: list[Result], | ||
| file_context: FileContext, | ||
| *codemod_args, | ||
| *codemod_args, # pylint: disable=unused-argument |
There was a problem hiding this comment.
Small thing but I think the idiomatic way to suppress this is with
del *codemod_argsAlthough possibly this argument is no longer needed?
andrecsilva
force-pushed
the
multi-fresource-leak
branch
from
f549be1 to
f380d9a
Compare
|
3 participants
Overview
fix-file-resource-leakwill now fix multiple leaks in a single block at once