change requests timeout codemod semgrep pattern#256
Merged
clavedeluna merged 1 commit intomainfrom Feb 13, 2024
Merged
Conversation
andrecsilva
approved these changes
Feb 13, 2024
drdavella
approved these changes
Feb 13, 2024
Member
drdavella
left a comment
drdavella
left a comment
There was a problem hiding this comment.
Nice fix! I'll backport a bugfix release once this is merged.
clavedeluna
force-pushed
the
fix-requests-timeout
branch
from
1c4b723 to
bfcdc6e
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
change semgrep rule for codemod to not match chained functions
Closes #244
More context: the only other codemod that suffers from this is the
bad-lock-with-statement. The issue there is the way we're using metavariable-pattern and focus-variable makes this fix not as easy.