Skip to content

Honor annotations in subprocess-shell-false#259

Merged
drdavella merged 6 commits intomainfrom
249-subprocess-shell-false-should-honor-noqa-s602
Feb 13, 2024
Merged

Honor annotations in subprocess-shell-false#259
drdavella merged 6 commits intomainfrom
249-subprocess-shell-false-should-honor-noqa-s602

Conversation

@drdavella
Copy link
Copy Markdown
Member

@drdavella drdavella commented Feb 13, 2024

Overview

subprocess-shell-false should not modify code that is explicitly annotated as safe

Details

  • In certain cases it is perfectly valid to use shell=True in subprocess calls
  • In such cases where there is an explicit annotation, we should honor it and not make this change

@drdavella drdavella linked an issue Feb 13, 2024 that may be closed by this pull request
@sonarqubecloud
Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
1 New issue

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@drdavella drdavella marked this pull request as ready for review February 13, 2024 16:52
@drdavella drdavella added this pull request to the merge queue Feb 13, 2024
Merged via the queue into main with commit 464d9c9 Feb 13, 2024
@drdavella drdavella deleted the 249-subprocess-shell-false-should-honor-noqa-s602 branch February 13, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

subprocess-shell-false should honor # noqa: S602

3 participants