Add filtering logic to use-defusedxml transformation#318
Merged
Conversation
|
andrecsilva
reviewed
Feb 29, 2024
Contributor
andrecsilva
left a comment
andrecsilva
left a comment
There was a problem hiding this comment.
I don't think this inclusion is actually doing anything. Line includes/excludes filtering should already be in place with the DefusedXmlModifier (i.e. in leave_Call for ImportedCallModifier) and this is not a result-based codemod. I'm gonna guess this change is for future-proofing, but I don't see any reason to include it right now.
Member
Author
|
@andrecsilva I should have included this in the description but I am using this codemod as the basis for a closed-source SAST remediation codemod and the filtering logic does not work without this change. |
andrecsilva
approved these changes
Feb 29, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Add filtering logic to use-defusedxml transformation