Hardening suggestions for codemodder-python / harden-pickle-load#333
Merged
Hardening suggestions for codemodder-python / harden-pickle-load#333
Conversation
![pixeebot[bot]](https://avatars.githubusercontent.com/in/193111?s=60&v=4){kind=small}
| requirements_path = "tests/samples/requirements.txt" | ||
| original_requirements = "# file used to test dependency management\nrequests==2.31.0\nblack==23.7.*\nmypy~=1.4\npylint>1\n" | ||
| expected_new_reqs = ( | ||
| f"# file used to test dependency management\n" |
Contributor
Author
There was a problem hiding this comment.
Remove unnecessary f-string
drdavella
force-pushed
the
harden-pickle-load
branch
from
0a4373b to
fa19a15
Compare
drdavella
approved these changes
Mar 5, 2024
Member
drdavella
left a comment
drdavella
left a comment
There was a problem hiding this comment.
Looks good. Need to rebase before merge.
drdavella
force-pushed
the
harden-pickle-load
branch
2 times, most recently
from
88ce86f to
3d88d85
Compare
drdavella
force-pushed
the
pixeebot/harden-pickle-load
branch
from
565e56c to
e1f3349
Compare
drdavella
approved these changes
Mar 6, 2024
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've reviewed the recently opened PR (332 - Add codemod
harden-pickle-load) and have identified some area(s) that could benefit from additional hardening measures.These changes should help prevent potential security vulnerabilities and improve overall code quality.
Thank you for your consideration!
docs | feedback
Powered by: pixeebot