New codemod to fix dataclass defaults#350
Merged
clavedeluna merged 6 commits intomainfrom Mar 11, 2024
Merged
Conversation
andrecsilva
approved these changes
Mar 11, 2024
drdavella
previously requested changes
Mar 11, 2024
Member
drdavella
left a comment
drdavella
left a comment
There was a problem hiding this comment.
Really nice codemod overall, thanks! Just requesting an update on the description.
Co-authored-by: Dan D'Avella <dan.davella@pixee.ai>
clavedeluna
force-pushed
the
dataclass-defaults
branch
from
8bf233a to
6438dee
Compare
|
clavedeluna
dismissed
drdavella’s stale review
implemented wording change requested
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This codemod will fix dataclass default values for list, dict, set, and replace it with the correct syntax
Description
Closes #250