Skip to content

Add detection tool metadata to CodeTF results#366

Merged
drdavella merged 2 commits intomainfrom
add-detection-tool
Mar 13, 2024
Merged

Add detection tool metadata to CodeTF results#366
drdavella merged 2 commits intomainfrom
add-detection-tool

Conversation

@drdavella
Copy link
Copy Markdown
Member

Overview

Add detection tool metadata to CodeTF results

Description

  • The CodeTF spec introduced a new detectionTool field: Add findings section to detectorTool codemodder-specs#21
  • This metadata will be used by downstream tooling for providing consistent presentation for tool remediation results
  • We will populate the findings field later since that is not needed right now

@sonarqubecloud
Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud



@dataclass
class ToolMetadata:
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since this is codetf related should it not be a pydantic class?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question: this is sort of intermediate metadata that isn't directly used for CodeTF generation so I think dataclass is okay.

@drdavella drdavella added this pull request to the merge queue Mar 13, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 13, 2024
@drdavella drdavella added this pull request to the merge queue Mar 13, 2024
Merged via the queue into main with commit 133ec48 Mar 13, 2024
@drdavella drdavella deleted the add-detection-tool branch March 13, 2024 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants