add detector name and update test utils #488
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drdavella
approved these changes
Apr 19, 2024
Member
drdavella
left a comment
drdavella
left a comment
There was a problem hiding this comment.
Approving to allow progress but we might need to consolidate this with ToolMetadata at some point.
clavedeluna
force-pushed
the
detector-names
branch
from
0b2d673 to
531e85f
Compare
|
Contributor
Author
|
removing name thing, just updating tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Update testing for extensions to test other languages and base detectors need a name to know which type of detector it is