Skip to content

Conversation

@clavedeluna
Copy link
Contributor

@clavedeluna clavedeluna commented Apr 22, 2024

Overview

Fix bug reported in issue where codemod was matching on a correct lazy logging line

Description

  • The fix is to change the semgrep pattern to not match acceptable args concatenation. This meant I had to do a bit of duplication in the pattern but that's worth it to fix this.

Fixes #487
I re-ran the codemodder command on the repo from the issue and this PR does indeed fix the error.

@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@clavedeluna clavedeluna marked this pull request as ready for review April 22, 2024 15:40
@drdavella drdavella added this pull request to the merge queue Apr 22, 2024
Merged via the queue into main with commit d16ff03 Apr 22, 2024
@drdavella drdavella deleted the 487-issue branch April 22, 2024 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

AttributeError in lazy logging codemod

2 participants