Skip to content

Gather results by rules #881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
drdavella merged 1 commit into from
Oct 16, 2024
Merged

Gather results by rules #881

drdavella merged 1 commit into from
Oct 16, 2024

Conversation

@drdavella
Copy link
Member

@drdavella drdavella commented Oct 16, 2024

Description

  • For multi-file codemods we need a finding-oriented view rather than a file-oriented view of results. This is because fixing a single finding could potentially require changes to multiple files

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 16, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

nahsra
nahsra approved these changes Oct 16, 2024
View reviewed changes
Copy link
Contributor

@nahsra nahsra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@drdavella drdavella added this pull request to the merge queue Oct 16, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 16, 2024
@drdavella drdavella added this pull request to the merge queue Oct 16, 2024
Merged via the queue into main with commit 79aac2e Oct 16, 2024
@drdavella drdavella deleted the results-by-rules branch October 16, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nahsra nahsra nahsra approved these changes

@andrecsilva andrecsilva Awaiting requested review from andrecsilva andrecsilva is a code owner

@clavedeluna clavedeluna Awaiting requested review from clavedeluna clavedeluna is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@drdavella @nahsra