Fix crash when writing BPM/cue data to TP-7 over MTP#37
Merged
Conversation
Use FileUtils.install instead of FileUtils.cp when writing the BPM/cue-updated temp file back to the target path. FileUtils.install removes the destination before copying and creates parent directories, which is required for MTP devices that don't support in-place overwrites. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
pixelate
force-pushed
the
claude/fix-tp7-mtp-write-crash
branch
from
ce5537b to
c6e232b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FileUtils.cpwithFileUtils.installwhen writing the BPM/cue-updated temp file back to the target path on the deviceFileUtils.installremoves the existing destination file before copying and creates parent directories, which is required for MTP devices (like the TP-7) that don't support in-place file overwritesFileUtils.cpwas failing withErrno::ENOENTbecause it tried to open the existing MTP file for writing directly, which MTP doesn't allow