Add Playdate (Kicooya) as a supported device#50
Merged
Conversation
pixelate
force-pushed
the
add-playdate-device
branch
2 times, most recently
from
029fa2f to
effeef1
Compare
Kicooya requires MP3 at 44.1 kHz. Since MP3 has no meaningful bit depth, make bit_depths optional on Device (defaults to []), and skip bit depth conversion when the device declares none. Select the ffmpeg audio codec based on the target file type so MP3 targets use libmp3lame instead of a PCM codec, which previously caused ffmpeg to reject the output stream. Also reset Logger's captured invocation args on reconfigure so stale state doesn't leak between tests when log_invocation short-circuits. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
pixelate
force-pushed
the
add-playdate-device
branch
from
effeef1 to
707194f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bit_depthsoptional onDevicesince MP3 has no meaningful bit depth; skip bit-depth conversion when the list is emptyTest plan
rakepasses (rubocop, steep, tests)/Data/com.abenokobo.kicooya/media/music/