Verify target file exists after sync writes#56
Merged
Conversation
1 task
pixelate
force-pushed
the
claude/wavesync-crystal-evaluation-A07eM
branch
from
736d767 to
f2c5a16
Compare
Log an error when the target file is missing after an acid-chunk write, copy, or conversion. Catches silent failures from MTP/FUSE mounts that accept writes without surfacing errors. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
pixelate
force-pushed
the
claude/verify-target-file-written
branch
from
334facc to
2c6fbf8
Compare
pixelate
changed the base branch from
claude/wavesync-crystal-evaluation-A07eM
to
main
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Scanner#verify_writtento log an error when the target file is missing after an acid-chunk write, copy, or conversion.Test plan
bundle exec rake test TEST=test/wavesync/scanner_test.rb?,:) and confirm aScanner#verify_writtenentry lands inwavesync.log.