Fix configure clearing invocation args before log_invocation can write them#58
Merged
Merged
Conversation
Logger.configure was resetting @invocation_args to nil, so the invocation captured by CLI.start was lost before parse_options could write it to the log. configure now only clears @invocation_args when called with nil (the reset path), leaving pending args intact when called with a real library path. Adds unit tests covering the configure-then-log sequence, and end-to-end tests that run sync and analyze through CLI.start against an empty library and assert the invocation appears in the log file.
pixelate
force-pushed
the
claude/log-command-invocations-Cys6J
branch
from
75fd5ae to
4317849
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Logger.configure was resetting @invocation_args to nil, which meant the
invocation captured by CLI.start was lost before parse_options could log it.
The args are already cleared by log_invocation after use, so configure only
needs to set the log path.